linux-kernel - Re: [PATCH] staging: rtl8192e: removed unnecessary white lines from crtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2017 18:53:17 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sumantro <saggy.zone@...il.com>
Cc:     devel@...verdev.osuosl.org, vishali.thakkar@...cle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: removed unnecessary white lines from
 crtl_wx.c

On Tue, Feb 28, 2017 at 08:16:25PM +0530, Sumantro wrote:
> staging:rtl8192e: removed extra whitelines which were giving warnings 
> Signed-off-by: Sumantro <saggy.zone@...il.com>

We need a blank line before the signed-off-by line, as well as a
"real/full" name being used (unless you use only "Sumantro" on legal
documents.)

Also, you need to be a bit more verbose in the changelog text, no need
to repeat the driver and subsystem name, it's up there in the subject
line.

Look at other patches for the driver for examples of what needs to be
done here.

thanks,

greg k-h