linux-kernel - Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM guest support code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Mar 2017 07:22:05 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        xen-devel@...ts.xenproject.org
Cc:     Boris Ostrovsky <boris.ostrovsky@...cle.com>, x86@...nel.org,
        Andrew Jones <drjones@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM
 guest support code

On 24/02/17 17:14, Vitaly Kuznetsov wrote:
> Introduce CONFIG_XEN_PV config option and split enlighten.c into
> 4 files. Temporary add #ifdef CONFIG_XEN_PV to smp.c and mmu.c to
> not break the build and not make the patch even bigger.
> 
> xen_cpu_up_prepare*/xen_cpu_die hooks require separation to support
> future xen_smp_intr_init() split.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Could you please split pure code movement and functional changes into
different patches? This would make review much easier.

So 1 patch to split up enlightenment.c and at least one patch for the
rest of the changes (Kconfig, splitting of x86_hyper_xen, ...).


Juergen