linux-kernel - Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Mar 2017 10:17:57 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface

On Wed, Mar 1, 2017 at 12:24 AM, Guenter Roeck <linux@...ck-us.net> wrote:
> On Tue, Feb 28, 2017 at 10:47:02PM +0100, Arnd Bergmann wrote:
>> On Tue, Feb 28, 2017 at 10:42 PM, Guenter Roeck <linux@...ck-us.net> wrote:
>> > On Tue, Feb 28, 2017 at 10:01:17PM +0100, Arnd Bergmann wrote:
>> >> When the db8500 watchdog is enabled without the PRCMU, we get a lot of
>> >> warnings about duplicate or missing helper functions:
>> >>
>> >> In file included from drivers/watchdog/ux500_wdt.c:21:0:
>> >> include/linux/mfd/dbx500-prcmu.h:422:19: error: redefinition of 'prcmu_abb_read'
>> >>  static inline int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size)
>> >>
>> >> This removes the duplicate function definitions and moves the helpers in
>> >> dbx500-prcmu outside of the #ifdef that hides them.
>> >>
>> >
>> > Is that appropriate ? Maybe we should just disable COMPILE_TEST
>> > for this driver instead.
>>
>> Or we could do both. The MFD driver was written to support this in principle,
>> it just hasn't worked in a long time.
>>
>
> Can you send me patches to disable COMPILE_TEST for this driver and for retu ?

Done.