linux-kernel - Re: e1000_netpoll() , BUG: sleeping function called from invalid context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2017 13:22:23 +0100
From:   Gabriel C <nix.or.die@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Cong Wang <xiyou.wangcong@...il.com>,
        lkml <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: e1000_netpoll() , BUG: sleeping function called from invalid
 context



On 02.03.2017 01:04, Gabriel C wrote:
>
>
>>> Does the patch below fix it?
>>
>> I'll test you patch in a bit and let you know.
>>
>
> It seem to work.
>
> But to be really sure I let the box running with this setup over night.
>

Also with 4.10.1 + your patch all seems fine..

The box is up 13 hours now and I cannot trigger the BUG()..

>>> 	
>>> 8<--------------
>>>
>>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>>> @@ -6716,19 +6716,19 @@ static irqreturn_t e1000_intr_msix(int _
>>>
>>>  		vector = 0;
>>>  		msix_irq = adapter->msix_entries[vector].vector;
>>> -		disable_irq(msix_irq);
>>> +		disable_hardirq(msix_irq);
>>>  		e1000_intr_msix_rx(msix_irq, netdev);
>>>  		enable_irq(msix_irq);
>>>
>>>  		vector++;
>>>  		msix_irq = adapter->msix_entries[vector].vector;
>>> -		disable_irq(msix_irq);
>>> +		disable_hardirq(msix_irq);
>>>  		e1000_intr_msix_tx(msix_irq, netdev);
>>>  		enable_irq(msix_irq);
>>>
>>>  		vector++;
>>>  		msix_irq = adapter->msix_entries[vector].vector;
>>> -		disable_irq(msix_irq);
>>> +		disable_hardirq(msix_irq);
>>>  		e1000_msix_other(msix_irq, netdev);
>>>  		enable_irq(msix_irq);
>>>  	}
>>>