[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Fri, 3 Mar 2017 00:21:49 -0600
From: Rob Herring <robh@...nel.org>
To: Chunyan Zhang <chunyan.zhang@...eadtrum.com>
Cc: mark.rutland@....com, gregkh@...uxfoundation.org,
catalin.marinas@....com, will.deacon@....com, arnd@...db.de,
orson.zhai@...eadtrum.com, sudeep.holla@....com,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, zhang.lyra@...il.com
Subject: Re: [PATCH V3 3/4] dt-bindings: serial: add a new compatible string
for SC9860
On Thu, Mar 02, 2017 at 02:22:09PM +0800, Chunyan Zhang wrote:
> SC9860 use the same serial device, so added a new compatible string to
> support SC9860 as well, also added an example of how to describe this
> serial device in DT.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@...eadtrum.com>
> ---
> Documentation/devicetree/bindings/serial/sprd-uart.txt | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> index 2aff0f2..8bd8144 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> @@ -1,7 +1,20 @@
> * Spreadtrum serial UART
>
> Required properties:
> -- compatible: must be "sprd,sc9836-uart"
> +- compatible must contain:
> + * "sprd,sc9836-uart" for SC9836 and all Spreadtrum SoCs
> + This also can be specific with:
> + * "sprd,sc9860-uart" for SC9860
Just say:
- compatible: must be one of:
"sprd,sc9836-uart"
"sprd,sc9860-uart", "sprd,sc9836-uart"
> +
> - reg: offset and length of the register set for the device
> - interrupts: exactly one interrupt specifier
> - clocks: phandles to input clocks.
> +
> +Example:
> + uart0: serial@...00000 {
> + compatible = "sprd,sc9860-uart",
> + "sprd,sc9836-uart";
> + reg = <0x000000 0x100>;
unit address doesn't match the reg property.
> + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ext_26m>;
> + };
> --
> 2.7.4
>
Powered by blists - more mailing lists