[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 03 Mar 2017 09:26:07 +0900
From: Andi Shyti <andi.shyti@...sung.com>
To: Hoegeun Kwon <hoegeun.kwon@...sung.com>
Cc: inki.dae@...sung.com, jy0922.shim@...sung.com,
sw0312.kim@...sung.com, airlied@...ux.ie, kgene@...nel.org,
krzk@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
catalin.marinas@....com, will.deacon@....com,
javier@....samsung.com, dri-devel@...ts.freedesktop.org,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/7] arm: dts: Add the burst and esc clock frequency
properties for exynos3250 dts
Hi Hoegeun,
On Thu, Mar 02, 2017 at 07:20:14PM +0900, Hoegeun Kwon wrote:
> The OF graph is not needed because the panel is a child of dsi. So
> added the burst and esc clock frequency properties to the parent (DSI
> node), taking into account the bisectability problem so that remove
> the OF graph from DSI node.
nitpick:
1. bisectability is not a problem (and for bisectability you
should not mention it in the commit log, you would confuse
bisecting people)
2. you should use the imperative form, not "added the burst... "
but "add the burst..."
Same for the other patches.
Andi
Powered by blists - more mailing lists