[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 3 Mar 2017 09:38:33 +0100
From: Marcin Ciupak <marcin.s.ciupak@...il.com>
To: Samuel Thibault <samuel.thibault@...-lyon.org>
Cc: William Hubbs <w.d.hubbs@...il.com>,
Chris Brannon <chris@...-brannons.com>,
Kirk Reiser <kirk@...sers.ca>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: replace simple_strtoul with kstrtou8
On Thu, Mar 02, 2017 at 04:17:12PM +0100, Samuel Thibault wrote:
> Marcin Ciupak, on jeu. 02 mars 2017 15:28:23 +0100, wrote:
> > - int val;
> > + int ret;
> >
> > - val = simple_strtoul(skip_spaces(start), &start, 10);
> > + ret = kstrtou8(skip_spaces(start), 10, dest);
>
> This is not the same, you need to have start properly move, since it's
> used below:
>
> > if (*start == ',')
> > start++;
> > - *dest = (u_char)val;
> > return start;
>
> Samuel
You are right, start is not updated by kstrtou8 like it is by
simple_strtoul.
If I understand it correctly simple_strtoul cannot be replaced by
kstrtou8 here.
Please discard this patch.
Marcin
Powered by blists - more mailing lists