lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Mar 2017 15:36:19 -0800 From: John Stultz <john.stultz@...aro.org> To: lkml <linux-kernel@...r.kernel.org> Cc: John Stultz <john.stultz@...aro.org>, Wei Xu <xuwei5@...ilicon.com>, Guodong Xu <guodong.xu@...aro.org>, Amit Pundir <amit.pundir@...aro.org>, Rob Herring <robh+dt@...nel.org>, John Youn <johnyoun@...opsys.com>, Douglas Anderson <dianders@...omium.org>, Chen Yu <chenyu56@...wei.com>, Felipe Balbi <felipe.balbi@...ux.intel.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org Subject: [PATCH] usb: dwc2: Make sure we disconnect the gadget state I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would properly initialize. The other times, I'd get a big WARN_ON in dwc2_hsotg_init_fifo() about the fifo_map not being clear. Ends up if we don't disconnect the gadget state, the fifo-map doesn't get cleared properly, which causes WARN_ON messages and also results in the device not properly being setup as a gadget every other time the OTG port is connected. So this patch adds a call to dwc2_hsotg_disconnect() in the reset path so the state is properly cleared. With it, the gadget interface initializes properly on every plug in. Cc: Wei Xu <xuwei5@...ilicon.com> Cc: Guodong Xu <guodong.xu@...aro.org> Cc: Amit Pundir <amit.pundir@...aro.org> Cc: Rob Herring <robh+dt@...nel.org> Cc: John Youn <johnyoun@...opsys.com> Cc: Douglas Anderson <dianders@...omium.org> Cc: Chen Yu <chenyu56@...wei.com> Cc: Felipe Balbi <felipe.balbi@...ux.intel.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: linux-usb@...r.kernel.org Acked-by: John Youn <johnyoun@...opsys.com> Signed-off-by: John Stultz <john.stultz@...aro.org> --- drivers/usb/dwc2/hcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index a73722e..91ed5b6 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -3264,6 +3264,7 @@ static void dwc2_conn_id_status_change(struct work_struct *work) dwc2_core_init(hsotg, false); dwc2_enable_global_interrupts(hsotg); spin_lock_irqsave(&hsotg->lock, flags); + dwc2_hsotg_disconnect(hsotg); dwc2_hsotg_core_init_disconnected(hsotg, false); spin_unlock_irqrestore(&hsotg->lock, flags); dwc2_hsotg_core_connect(hsotg); -- 2.7.4
Powered by blists - more mailing lists