linux-kernel - Re: [PATCH] mmc: core: fix changing bus witdh in hs400es mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2017 11:43:05 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Piotr Sroka <piotrs@...ence.com>
Cc:     linux-mmc@...r.kernel.org, shawn.lin@...k-chips.com,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        Gwendal Grignou <gwendal@...omium.org>,
        Dong Aisheng <aisheng.dong@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: core: fix changing bus witdh in hs400es mode

Hi Poitr,

On 2017/3/2 21:47, Piotr Sroka wrote:
> Fix the code to avoid changing bus width if HS400ES mode is selected.
>

Thanks for catching this, but Guenter posted a fix[1] already. :)

[1]: https://patchwork.kernel.org/patch/9599261/

> Signed-off-by: Piotr Sroka <piotrs@...ence.com>
> ---
>  drivers/mmc/core/mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 7fd7228..c7d9c9f 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>  		err = mmc_select_hs400(card);
>  		if (err)
>  			goto free_card;
> -	} else {
> +	} else if (!mmc_card_hs400(card)) {
>  		/* Select the desired bus width optionally */
>  		err = mmc_select_bus_width(card);
>  		if (err > 0 && mmc_card_hs(card)) {
>


-- 
Best Regards
Shawn Lin