linux-kernel - Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Mar 2017 07:53:38 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mark Stenglein <mark@...ngle.in>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding
 style issue

On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> Fixed a coding style issue.

What issue would that be?

> Signed-off-by: Mark Stenglein <mark@...ngle.in>
> ---
>  drivers/staging/wlan-ng/hfa384x.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c85f12..f19984747b1e 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
>  	enum ctlx_state state;	/* Tracks running state */
>  
>  	struct completion done;
> +
>  	volatile int reapable;	/* Food for the reaper task */

What is wrong with the original code here?

Please don't blindly trust checkpatch.pl all the time, sometimes you
have to use your brain when reading the results.

thanks,

greg k-h