linux-kernel - Re: [PATCH 0/2] HID: Corsair Scimitar Pro RGB gaming mouse driver and support for other Corsair devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Mar 2017 21:09:36 +0000
From:   Oscar Campos <damnwidget@...il.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] HID: Corsair Scimitar Pro RGB gaming mouse driver
 and support for other Corsair devices

On Mon, Mar 06, 2017 at 01:55:21PM +0100, Jiri Kosina wrote:
> On Fri, 10 Feb 2017, Oscar Campos wrote:
>
> > Since I have a Corsair Scimitar PRO RGB that does not works on Linux, I
> > tried to find a solution doing some research but was not able to find any.
> [ ... snip ... ]
> >
> > I created the new mouse driver instead of add code to the already existent
> > `hid-corsair.c` as it seem quite common to split mouse and keyboard driver
> > support.
>
> Hi Oscar,
>
> thanks a lot for the patch.
>
> Keeping the support in hid-corsair would be prefered. I think the only
> driver where we have the major kbd/mouse split is Holtek, which if I
> remember correctly was my fault not having catched this during review; it
> should probably eventually be unified.
>
> Otherwsie, we don't really distinguish the device type (the HID land is
> much wider than mice and keyboards anyway), but in most cases by the
> vendor.
>
> Could you please resubmit the patch so that it's actually adding changes
> to hid-corsair? Thanks!

I did send a [PATCH v2 2/2] that adds the changes to hid-corsair and
rollback any uneeded changes into the Kconfig and Makefile files. I also
added the vendor/product_id into the hid_have_special_driver[] array as
suggested.

>
> --
> Jiri Kosina
> SUSE Labs
>

Regards