linux-kernel - Re: [PATCH 10/26] IB/ocrdma: Improve another size determination in ocrdma_init_emb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2017 20:12:03 +0530
From:   Devesh Sharma <devesh.sharma@...adcom.com>
To:     Yuval Shaia <yuval.shaia@...cle.com>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Devesh Sharma <devesh.sharma@...gotech.com>,
        Doug Ledford <dledford@...hat.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Selvin Xavier <selvin.xavier@...gotech.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 10/26] IB/ocrdma: Improve another size determination in ocrdma_init_emb_mqe()

Acked-by: Devesh Sharma <devesh.sharma@...adcom.com>

On Wed, Mar 8, 2017 at 7:52 PM, Yuval Shaia <yuval.shaia@...cle.com> wrote:
> On Wed, Mar 08, 2017 at 02:02:46PM +0100, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@...rs.sourceforge.net>
>> Date: Tue, 7 Mar 2017 20:33:29 +0100
>>
>> Replace the specification of a data structure by a pointer dereference
>> as the parameter for the operator "sizeof" to make the corresponding size
>> determination a bit safer according to the Linux coding style convention.
>>
>> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
>> ---
>>  drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> index 7d1e1caa90de..aa32bc9f323d 100644
>> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> @@ -352,7 +352,7 @@ static void *ocrdma_init_emb_mqe(u8 opcode, u32 cmd_len)
>>  {
>>       struct ocrdma_mqe *mqe;
>>
>> -     mqe = kzalloc(sizeof(struct ocrdma_mqe), GFP_KERNEL);
>> +     mqe = kzalloc(sizeof(*mqe), GFP_KERNEL);
>>       if (!mqe)
>>               return NULL;
>>       mqe->hdr.spcl_sge_cnt_emb |=
>
> Reviewed-by: Yuval Shaia <yuval.shaia@...cle.com>
>
>> --
>> 2.12.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html