linux-kernel - Re: [PATCH 22/26] IB/ocrdma: Returning only value constants in ocrdma_resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2017 20:46:03 +0530
From:   Devesh Sharma <devesh.sharma@...adcom.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-rdma <linux-rdma@...r.kernel.org>,
        Devesh Sharma <devesh.sharma@...gotech.com>,
        Doug Ledford <dledford@...hat.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Selvin Xavier <selvin.xavier@...gotech.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 22/26] IB/ocrdma: Returning only value constants in ocrdma_resize_cq()

Acked-By:Devesh Sharma <devesh.sharma@...adcom.com>

On Wed, Mar 8, 2017 at 6:56 PM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 8 Mar 2017 10:48:24 +0100
>
> Return constant integer values without storing them in the local
> variable "status".
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index bedc229be89d..1d25512416f5 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -1123,15 +1123,12 @@ struct ib_cq *ocrdma_create_cq(struct ib_device *ibdev,
>  int ocrdma_resize_cq(struct ib_cq *ibcq, int new_cnt,
>                      struct ib_udata *udata)
>  {
> -       int status = 0;
>         struct ocrdma_cq *cq = get_ocrdma_cq(ibcq);
>
> -       if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) {
> -               status = -EINVAL;
> -               return status;
> -       }
> +       if (new_cnt < 1 || new_cnt > cq->max_hw_cqe)
> +               return -EINVAL;
>         ibcq->cqe = new_cnt;
> -       return status;
> +       return 0;
>  }
>
>  static void ocrdma_flush_cq(struct ocrdma_cq *cq)
> --
> 2.12.0
>