linux-kernel - RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2017 02:36:38 +0000
From:   Masaki Ota <masaki.ota@...alps.com>
To:     "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>
CC:     Paul Donohue <linux-kernel@...lsd.com>,
        Nick Fletcher <nick.m.fletcher@...il.com>,
        Joseph Salisbury <joseph.salisbury@...onical.com>,
        "ben@...rt-cactus.org" <ben@...rt-cactus.org>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "pali.rohar@...il.com" <pali.rohar@...il.com>,
        "rydberg@...math.org" <rydberg@...math.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag
 for 74 03 28 devices

Hi, Dmitry,

OK, I will do it.

Best Regards,
Masaki Ota
-----Original Message-----
From: dmitry.torokhov@...il.com [mailto:dmitry.torokhov@...il.com] 
Sent: Wednesday, March 08, 2017 2:58 AM
To: 太田 真喜 Masaki Ota <masaki.ota@...alps.com>
Cc: Paul Donohue <linux-kernel@...lsd.com>; Nick Fletcher <nick.m.fletcher@...il.com>; Joseph Salisbury <joseph.salisbury@...onical.com>; ben@...rt-cactus.org; mhocko@...e.com; pali.rohar@...il.com; rydberg@...math.org; linux@...ck-us.net; open list:HID CORE LAYER <linux-input@...r.kernel.org>; LKML <linux-kernel@...r.kernel.org>; stable@...r.kernel.org
Subject: Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

Hi Masaki,

On Tue, Mar 07, 2017 at 08:40:20AM +0000, Masaki Ota wrote:
> Hi, Paul,
> 
> I have modified the source code. 
> 
> There are three issues.
> #1. E7=73 03 28 Button pad device is not assigned "ALPS_BUTTONPAD" Flag correctly.
> #2. E7=73 03 28 devices are not assigned " ALPS_DUALPOINT" Flag correctly.
> #3. E7=73 03 28 device cursor speed is slow.
> 
> Actually, the cause is all the same.
> E7=73 03 28 device does not get correct information from OTP.
> OTP is the device information byte. I specified correct bit.
> 
> Then, I think it is also the issue.
> #4. Stick Pointer cursor speed is fast.
> 
> I will check Stick parameter.

Could you please submit this as a proper patch now that we have confirmation that it works? Also, I wonder if V8PLUS should be full protocol instead of a flag.

Thanks.

--
Dmitry