linux-kernel - Re: [PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Mar 2017 09:17:00 +0200
From:   Roger Quadros <rogerq@...com>
To:     <balbi@...nel.org>
CC:     <Peter.Chen@....com>, <gregkh@...uxfoundation.org>,
        <garsilva@...eddedor.com>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, "#v4 . 8+" <stable@...r.kernel.org>
Subject: Re: [PATCH 1/3] usb: dwc3-omap: Fix missing break in
 dwc3_omap_set_mailbox()

Felipe,

On 15/02/17 13:38, Roger Quadros wrote:
> We need to break from all cases if we want to treat
> each one of them separately.
> 
> Reported-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently")
> Cc: <stable@...r.kernel.org> #v4.8+
> Signed-off-by: Roger Quadros <rogerq@...com>

Can you please pick this one for v4.11-rc? Thanks.

> ---
>  drivers/usb/dwc3/dwc3-omap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index eb1b9cb..35b6351 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -250,6 +250,7 @@ static void dwc3_omap_set_mailbox(struct dwc3_omap *omap,
>  		val = dwc3_omap_read_utmi_ctrl(omap);
>  		val |= USBOTGSS_UTMI_OTG_CTRL_IDDIG;
>  		dwc3_omap_write_utmi_ctrl(omap, val);
> +		break;
>  
>  	case OMAP_DWC3_VBUS_OFF:
>  		val = dwc3_omap_read_utmi_ctrl(omap);
> 

-- 
cheers,
-roger