lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 11 Mar 2017 16:11:27 +0800
From:   kbuild test robot <lkp@...el.com>
To:     sunil.m@...hveda.org
Cc:     kbuild-all@...org, gregkh@...uxfoundation.org,
        dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, suniel.spartan@...il.com,
        Suniel Mahesh <sunil.m@...hveda.org>
Subject: Re: [PATCH v2 1/5] staging: rtl8192e: Fix coding style issues

Hi Suniel,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.11-rc1 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/sunil-m-techveda-org/staging-rtl8192e-Fix-coding-style-warnings-and-checks/20170311-122226
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/staging/rtl8192e/rtl8192e/rtl_core.c: In function 'rtl92e_set_rf_state':
>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:220:13: error: 'WLAN_REASON_DISASSOC_STA_' undeclared (first use in this function)
                WLAN_REASON_DISASSOC_STA_
                ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:220:13: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:221:9: error: expected ')' before 'HAS_LEFT'
            HAS_LEFT);
            ^~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c: In function '_rtl92e_if_silent_reset':
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1248:24: warning: missing terminating " character
      RT_TRACE(COMP_RESET, "%s():======>start to down the
                           ^
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1249:13: warning: missing terminating " character
        driver\n",  __func__);
                ^
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1252:5: warning: missing terminating " character
        "%s():111111111111111111111111======>start to down the
        ^
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1253:13: warning: missing terminating " character
        driver\n",  __func__);
                ^
>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2752:0: error: unterminated argument list invoking macro "RT_TRACE"
    MODULE_PARM_DESC(channels, " Channel bitmask for specific locales. NYI");
    
>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1248:3: error: 'RT_TRACE' undeclared (first use in this function)
      RT_TRACE(COMP_RESET, "%s():======>start to down the
      ^~~~~~~~
>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1248:3: error: expected ';' at end of input
>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1248:3: error: expected declaration or statement at end of input
>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1248:3: error: expected declaration or statement at end of input
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1233:1: warning: label 'RESET_START' defined but not used [-Wunused-label]
    RESET_START:
    ^~~~~~~~~~~
>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1227:4: error: label 'END' used but not defined
       goto END;
       ^~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1218:24: warning: unused variable 'ieee' [-Wunused-variable]
     struct rtllib_device *ieee = priv->rtllib;
                           ^~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1217:6: warning: unused variable 'reset_status' [-Wunused-variable]
     int reset_status = 0;
         ^~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1216:5: warning: unused variable 'reset_times' [-Wunused-variable]
     u8 reset_times = 0;
        ^~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c: At top level:
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:71:12: warning: '_rtl92e_pci_probe' used but never defined
    static int _rtl92e_pci_probe(struct pci_dev *pdev,
               ^~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:73:13: warning: '_rtl92e_pci_disconnect' used but never defined
    static void _rtl92e_pci_disconnect(struct pci_dev *pdev);
                ^~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:74:20: warning: '_rtl92e_irq' used but never defined
    static irqreturn_t _rtl92e_irq(int irq, void *netdev);
                       ^~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:86:13: warning: '_rtl92e_watchdog_wq_cb' used but never defined
    static void _rtl92e_watchdog_wq_cb(void *data);
                ^~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:87:13: warning: '_rtl92e_watchdog_timer_cb' used but never defined
    static void _rtl92e_watchdog_timer_cb(unsigned long data);
                ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:88:13: warning: '_rtl92e_hard_data_xmit' used but never defined
    static void _rtl92e_hard_data_xmit(struct sk_buff *skb, struct net_device *dev,
                ^~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:90:12: warning: '_rtl92e_hard_start_xmit' used but never defined
    static int _rtl92e_hard_start_xmit(struct sk_buff *skb, struct net_device *dev);
               ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:91:13: warning: '_rtl92e_tx_cmd' declared 'static' but never defined [-Wunused-function]
    static void _rtl92e_tx_cmd(struct net_device *dev, struct sk_buff *skb);
                ^~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:92:14: warning: '_rtl92e_tx' declared 'static' but never defined [-Wunused-function]
    static short _rtl92e_tx(struct net_device *dev, struct sk_buff *skb);
                 ^~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:93:14: warning: '_rtl92e_pci_initdescring' used but never defined
    static short _rtl92e_pci_initdescring(struct net_device *dev);
                 ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:94:13: warning: '_rtl92e_irq_tx_tasklet' used but never defined
    static void _rtl92e_irq_tx_tasklet(struct r8192_priv *priv);
                ^~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:95:13: warning: '_rtl92e_irq_rx_tasklet' used but never defined
    static void _rtl92e_irq_rx_tasklet(struct r8192_priv *priv);
                ^~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:96:13: warning: '_rtl92e_cancel_deferred_work' used but never defined
    static void _rtl92e_cancel_deferred_work(struct r8192_priv *priv);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:97:12: warning: '_rtl92e_up' declared 'static' but never defined [-Wunused-function]
    static int _rtl92e_up(struct net_device *dev, bool is_silent_reset);
               ^~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:98:12: warning: '_rtl92e_try_up' declared 'static' but never defined [-Wunused-function]
    static int _rtl92e_try_up(struct net_device *dev);
               ^~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:99:12: warning: '_rtl92e_down' declared 'static' but never defined [-Wunused-function]
    static int _rtl92e_down(struct net_device *dev, bool shutdownrf);
               ^~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:100:13: warning: '_rtl92e_restart' used but never defined
    static void _rtl92e_restart(void *data);
                ^~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1213:13: warning: '_rtl92e_if_silent_reset' defined but not used [-Wunused-function]
    static void _rtl92e_if_silent_reset(struct net_device *dev)
                ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1181:24: warning: '_rtl92e_if_check_reset' defined but not used [-Wunused-function]
    static enum reset_type _rtl92e_if_check_reset(struct net_device *dev)
                           ^~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1051:14: warning: '_rtl92e_init' defined but not used [-Wunused-function]
    static short _rtl92e_init(struct net_device *dev)
                 ^~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:776:12: warning: '_rtl92e_sta_down' defined but not used [-Wunused-function]
    static int _rtl92e_sta_down(struct net_device *dev, bool shutdownrf)
               ^~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:733:12: warning: '_rtl92e_sta_up' defined but not used [-Wunused-function]
    static int _rtl92e_sta_up(struct net_device *dev, bool is_silent_reset)
               ^~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:275:13: warning: '_rtl92e_tx_timeout' defined but not used [-Wunused-function]
    static void _rtl92e_tx_timeout(struct net_device *dev)
                ^~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:76:26: warning: 'rtl8192_pci_driver' defined but not used [-Wunused-variable]
    static struct pci_driver rtl8192_pci_driver = {
                             ^~~~~~~~~~~~~~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:38:14: warning: 'ifname' defined but not used [-Wunused-variable]
    static char *ifname = "wlan%d";
                 ^~~~~~
   drivers/staging/rtl8192e/rtl8192e/rtl_core.c:37:12: warning: 'channels' defined but not used [-Wunused-variable]
    static int channels = 0x3fff;
               ^~~~~~~~

vim +/WLAN_REASON_DISASSOC_STA_ +220 drivers/staging/rtl8192e/rtl8192e/rtl_core.c

   214				    (ChangeSource > RF_CHANGE_BY_IPS)) {
   215					if (ieee->state == RTLLIB_LINKED)
   216						priv->blinked_ingpio = true;
   217					else
   218						priv->blinked_ingpio = false;
   219					rtllib_MgntDisconnect(priv->rtllib,
 > 220							      WLAN_REASON_DISASSOC_STA_
 > 221									HAS_LEFT);
   222				}
   223			}
   224			if ((ChangeSource == RF_CHANGE_BY_HW) && !priv->bHwRadioOff)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (38803 bytes)

Powered by blists - more mailing lists