linux-kernel - Re: [PATCH] staging: wlan-ng: fix checkpatch.pl code style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Mar 2017 15:16:34 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Andrii <tulup@...l.ru>
Cc:     sergio.paracuellos@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: fix checkpatch.pl code style warnings

On Sat, Mar 11, 2017 at 10:39:56PM +0200, Andrii wrote:
> Fixed code style warnings reported by checkpatch.pl script.

What warning would that be?  Please always be very specific.

> 
> Signed-off-by: Andrii Vladyka <tulup@...l.ru> 

Trailing whitespace on this line :(


> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 6134eba..d7d2d13 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1346,14 +1346,10 @@ hfa384x_docmd(struct hfa384x *hw,
>  	} else if (mode == DOWAIT) {
>  		struct usbctlx_cmd_completor completor;
>  
> -		result =
> -		    hfa384x_usbctlx_complete_sync(hw, ctlx,
> -						  init_cmd_completor(&completor,
> -								     &ctlx->
> -								     inbuf.
> -								     cmdresp,
> -								     &cmd->
> -								     result));
> +		result = hfa384x_usbctlx_complete_sync(hw, ctlx,
> +						init_cmd_completor(&completor,
> +							&ctlx->inbuf.cmdresp,
> +							&cmd->result));

It's still a pain to read, can't there be a better way to rewite the
code to be readable?

thanks,

greg k-h