lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Mar 2017 17:19:01 -0700 From: Subhash Jadavani <subhashj@...eaurora.org> To: Tomas Winkler <tomas.winkler@...el.com> Cc: James Bottomley <James.Bottomley@...senpartnership.com>, "Martin K . Petersen" <martin.petersen@...cle.com>, Vinayak Holikatti <vinholikatti@...il.com>, Christoph Hellwig <hch@....de>, Yaniv Gardi <ygardi@...eaurora.org>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [scsi] scsi: ufs: don't check unsigned type for a negative value On 2017-03-12 03:22, Tomas Winkler wrote: > Fix compilation warning > > drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned > expression < 0 is always false [-Wtype-limits] > if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX)) > > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com> > --- > drivers/scsi/ufs/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 1359913bf840..e8c26e6e6237 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -7642,7 +7642,7 @@ static inline ssize_t ufshcd_pm_lvl_store(struct > device *dev, > if (kstrtoul(buf, 0, &value)) > return -EINVAL; > > - if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX)) > + if (value >= UFS_PM_LVL_MAX) > return -EINVAL; > > spin_lock_irqsave(hba->host->host_lock, flags); LGTM. Reviewed-by: Subhash Jadavani <subhashj@...aurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Powered by blists - more mailing lists