linux-kernel - Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2017 19:40:33 -0700
From:   lkml@...garu.com
To:     "Brown, Aaron F" <aaron.f.brown@...el.com>
Cc:     Bjørn Mork <bjorn@...k.no>,
        Borislav Petkov <bp@...en8.de>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "vcaputo@...garu.com" <vcaputo@...garu.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        khalidm <khalidm@...co.com>,
        David Singleton <davsingl@...co.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
Subject: Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

On Tue, Mar 14, 2017 at 01:20:27AM +0000, Brown, Aaron F wrote:
> > Borislav Petkov <bp@...en8.de> writes:
> > > On Sun, Mar 12, 2017 at 03:55:08PM +0200, Andy Shevchenko wrote:
> > >
> > >> The only change that IMHO matters happened between v4.10 and v4.11-
> > rc1 is this:
> > >>
> > >> @@ -6276,8 +6274,8 @@ static int e1000e_pm_freeze(struct device *dev)
> > >>                 /* Quiesce the device without resetting the hardware */
> > >>                 e1000e_down(adapter, false);
> > >>                 e1000_free_irq(adapter);
> > >> +               e1000e_reset_interrupt_capability(adapter);
> > >>         }
> > >> -       e1000e_reset_interrupt_capability(adapter);
> > >>
> > >> So, it apparently misses something for the other case, like
> > >> pci_disable_msi() call or so.
> > >
> > > Well, lemme add the people from
> > >
> > >   7e54d9d063fa ("e1000e: driver trying to free already-free irq")
> > >
> > > to CC then. :-)
> > 
> > Already did that a week ago:
> > https://www.spinics.net/lists/netdev/msg423379.html
> > 
> > Haven't heard anything back yet.  Wondering if they are waiting for
> > someone else to submit the pretty obvious revert?  Don't understand why
> > that should take more than a minute to figure out.  It's not like they
> > are testing these changes anyway...
> 
<snip>
> 
> What exact part (or parts) are we looking at (lspci|grep -i eth) that trigger this?  Could it be a difference in .config files?  The trace says it is falling back to legacy interrupts, does the system continue to work and does the network continue to function in that mode?  In case it's related to user space what is the base distro?  Any other information you think can help me reproduce the issue would be appreciated.
> 

Config attached, the machine is a Thinkpad X61s 1.8Ghz with no onboard wireless
devices (rtl8192cu usb wifi is used).

# lspci| grep -i eth
00:19.0 Ethernet controller: Intel Corporation 82566MM Gigabit Network Connection (rev 03)

Debian jessie amd64 is the distro.

I'll have to get back to you on if the e1000e continues functioning, the
machine continues to function until the shutdown panic.

There were however some occurrences of subsequent suspend/resume cycles hanging
the machine hard leaving the display off, which prompted me to resume using
4.10 before digging any further as it's my only system right now.

Will try get around to testing 4.11 with 7e54d9d063fa reverted soon.

Regards,
Vito Caputo

View attachment "linux-4.11.0-rc1-x61s.config" of type "text/plain" (106546 bytes)