linux-kernel - Re: [RFC PATCH] drivers: ata: Add [save|restore]_initial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 17:30:32 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>
Cc:     Hans de Goede <hdegoede@...hat.com>, anirudh@...inx.com,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        Anurag Kumar Vulisha <anuragku@...inx.com>
Subject: Re: [RFC PATCH] drivers: ata: Add [save|restore]_initial_config
 override functions

On Tue, Mar 14, 2017 at 05:29:21PM +0530, Anurag Kumar Vulisha wrote:
> @@ -613,7 +613,10 @@ static void ahci_pci_save_initial_config(struct pci_dev *pdev,
>  			  "Disabling your PATA port. Use the boot option 'ahci.marvell_enable=0' to avoid this.\n");
>  	}
>  
> -	ahci_save_initial_config(&pdev->dev, hpriv);
> +	if (hpriv->save_initial_config == NULL)
> +		ahci_save_initial_config(dev, hpriv);
> +	else
> +		hpriv->save_initial_config(dev, hpriv);

Can you just initialize hpriv->save_initial_config to
ahci_save_initial_config and let the init function override it as
necessary?

Thanks.

-- 
tejun