linux-kernel - Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 11:56:27 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening
 printks

On Wed 15-03-17 18:43:13, Joe Perches wrote:
> Function calls with large argument counts cause x86-64 register
> spilling.  Reducing the number of arguments in a multi-line printk
> by converting to multiple printks which saves some object code size.
> 
> $ size mm/page_alloc.o* (defconfig)
>    text    data     bss     dec     hex filename
>   35914	   1699	    628	  38241	   9561	mm/page_alloc.o.new
>   36018    1699     628   38345    95c9 mm/page_alloc.o.old
> 
> Miscellanea:
> 
> o Remove line leading spaces from the formerly multi-line printks
>   commit a25700a53f71 ("mm: show bounce pages in oom killer output")
>   back in 2007 started the leading space when a single long line
>   was split into multiple lines but the leading space was likely
>   mistakenly kept and subsequent commits followed suit.
> o Align arguments in a few more printks

This is really hard to review. Could you just drop all the whitespace
changes please?
-- 
Michal Hocko
SUSE Labs