linux-kernel - Re: [PATCH v4 4/7] mfd: rk808: Add RK805 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2017 08:19:23 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Elaine Zhang <zhangqing@...k-chips.com>
Cc:     kbuild-all@...org, lee.jones@...aro.org, lgirdwood@...il.com,
        broonie@...nel.org, huangtao@...k-chips.com, xxx@...k-chips.com,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        chenjh@...k-chips.com, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, w.egorov@...tec.de,
        Elaine Zhang <zhangqing@...k-chips.com>
Subject: Re: [PATCH v4 4/7] mfd: rk808: Add RK805 support

Hi Elaine,

[auto build test WARNING on ljones-mfd/for-mfd-next]
[also build test WARNING on v4.11-rc2 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Elaine-Zhang/rk808-Add-RK805-support/20170320-073457
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: i386-randconfig-x073-201712 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/mfd/rk808.c: In function 'rk808_probe':
>> drivers/mfd/rk808.c:547:16: warning: 'pm_pwroff_fn' may be used uninitialized in this function [-Wmaybe-uninitialized]
      pm_power_off = pm_pwroff_fn;
      ~~~~~~~~~~~~~^~~~~~~~~~~~~~

vim +/pm_pwroff_fn +547 drivers/mfd/rk808.c

2eedcbfc0 Wadim Egorov    2016-08-29  531  			return ret;
2eedcbfc0 Wadim Egorov    2016-08-29  532  		}
2eedcbfc0 Wadim Egorov    2016-08-29  533  	}
f69a7cf74 Chris Zhong     2014-09-03  534  
2eedcbfc0 Wadim Egorov    2016-08-29  535  	ret = devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE,
2eedcbfc0 Wadim Egorov    2016-08-29  536  			      cells, nr_cells, NULL, 0,
d5623161a Laxman Dewangan 2016-04-08  537  			      regmap_irq_get_domain(rk808->irq_data));
f69a7cf74 Chris Zhong     2014-09-03  538  	if (ret) {
f69a7cf74 Chris Zhong     2014-09-03  539  		dev_err(&client->dev, "failed to add MFD devices %d\n", ret);
f69a7cf74 Chris Zhong     2014-09-03  540  		goto err_irq;
f69a7cf74 Chris Zhong     2014-09-03  541  	}
f69a7cf74 Chris Zhong     2014-09-03  542  
f69a7cf74 Chris Zhong     2014-09-03  543  	pm_off = of_property_read_bool(np,
f69a7cf74 Chris Zhong     2014-09-03  544  				"rockchip,system-power-controller");
f69a7cf74 Chris Zhong     2014-09-03  545  	if (pm_off && !pm_power_off) {
f69a7cf74 Chris Zhong     2014-09-03  546  		rk808_i2c_client = client;
b2e2c8509 Jianhong Chen   2016-10-17 @547  		pm_power_off = pm_pwroff_fn;
f69a7cf74 Chris Zhong     2014-09-03  548  	}
f69a7cf74 Chris Zhong     2014-09-03  549  
f69a7cf74 Chris Zhong     2014-09-03  550  	return 0;
f69a7cf74 Chris Zhong     2014-09-03  551  
f69a7cf74 Chris Zhong     2014-09-03  552  err_irq:
f69a7cf74 Chris Zhong     2014-09-03  553  	regmap_del_irq_chip(client->irq, rk808->irq_data);
f69a7cf74 Chris Zhong     2014-09-03  554  	return ret;
f69a7cf74 Chris Zhong     2014-09-03  555  }

:::::: The code at line 547 was first introduced by commit
:::::: b2e2c85091710159b305735d557f4ef4695f5dff mfd: rk808: RK818 uses DEV_OFF to power off supplies

:::::: TO: Jianhong Chen <chenjh@...k-chips.com>
:::::: CC: Lee Jones <lee.jones@...aro.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (26075 bytes)