linux-kernel - Re: [PATCHv2 00/10] Nokia N950 basic display support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2017 13:29:35 +0200
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Sebastian Reichel <sre@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:     David Airlie <airlied@...ux.ie>, <linux-omap@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 00/10] Nokia N950 basic display support

Hi,

On 05/03/17 01:50, Sebastian Reichel wrote:
> Hi,
> 
> Some of you may remember, that I sent a series for the N950 display
> some time ago. N950 has command mode DSI panel, so the main part of
> the patchset takes care of adding manual display update support in
> omapdrm.
> 
> The N950 also requires display rotation (the panel is mounted vertically
> and bottom-up) and offset. The required bits will be sent separately.
> 
> The patchset is based on 2d62e0768d3c, which is the current commit
> torvald's master branch points to. I tested the patches on N950
> with kernel console (fbcon), Tomi's kmstest and Xorg from Debian sid.
> 
> Rough changelog, most of that work was done by Tony (thanks!)
> 
>  * lots of patches dropped for now
>  * rebased to current omapdrm interface
>  * added OMAP4 support
>  * misc. cleanup

I haven't been able to go through this series with time, but looking at
the patches, there were multiple places where I felt quite uneasy with
the changes. It didn't help that many of the patches did not have
descriptions.

So as an RFC series, it's quite nice and shows that the manual update
can be gotten to work. But I'm not ready to apply this until the patches
touching the omapdrm enable, disable and commit sequences are split up
into smaller patches with proper descriptions.

Also, a minor note that rotating the display on N950 will cause tearing.
Probably not a huge issue, though.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)