linux-kernel - Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2017 15:08:45 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     lgirdwood@...il.com, bardliao@...ltek.com, oder_chiou@...ltek.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell
 XPS 9343 I2S mode

On Mon, Mar 20, 2017 at 11:58:31AM +0800, Kai-Heng Feng wrote:

> v3:
> Implicit conversion instead of tenary operator.
> 
> v2:
> Use 'HP Power' instead of individual power events.

As covered in SubmittingPatches this should come after the ---, it
doesn't need to end up in the changelogs.

> +	switch (event) {
> +	case SND_SOC_DAPM_PRE_PMD:
> +	case SND_SOC_DAPM_POST_PMD:
> +	case SND_SOC_DAPM_POST_PMU:
> +		snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, AMP_OUT_MUTE);
> +		break;
> +	case SND_SOC_DAPM_PRE_PMU:

To repeat what I said last time:

| After power up we mute the amplifier?  That's worthy of a comment...

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)