linux-kernel - Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2017 00:11:32 -0700
From:   "Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:     Manish Narani <manish.narani@...inx.com>
Cc:     balbi@...nel.org, gregkh@...uxfoundation.org, xypron.glpk@....de,
        mnarani@...inx.com, bart.vanassche@...disk.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        anirudh@...inx.com, svemula@...inx.com,
        target-devel <target-devel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status
 request

Hi Manish,

(Added target-devel CC')

On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
> This patch corrects the argument in usb_ep_free_request as it is
> mistakenly set to ep_out. It should be ep_in for status request.
> 
> Signed-off-by: Manish Narani <mnarani@...inx.com>
> ---
>  drivers/usb/gadget/function/f_tcm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
> index d235113..a82e2bd 100644
> --- a/drivers/usb/gadget/function/f_tcm.c
> +++ b/drivers/usb/gadget/function/f_tcm.c
> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
>  	usb_ep_free_request(fu->ep_in, fu->bot_req_in);
>  	usb_ep_free_request(fu->ep_out, fu->bot_req_out);
>  	usb_ep_free_request(fu->ep_out, fu->cmd.req);
> -	usb_ep_free_request(fu->ep_out, fu->bot_status.req);
> +	usb_ep_free_request(fu->ep_in, fu->bot_status.req);
>  
>  	kfree(fu->cmd.buf);
>  

Applied to target-pending/master.

Thanks!