linux-kernel - Re: [PATCH v2] HID: remove initial reading of reports at connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2017 15:00:32 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        David Herrmann <dh.herrmann@...glemail.com>,
        Oliver Neukum <oneukum@...e.de>,
        Jason Gerecke <killertofu@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] HID: remove initial reading of reports at connect

On Wed, 8 Mar 2017, Benjamin Tissoires wrote:

> It looks like a bunch of devices do not like to be polled for their 
> reports at init time. When you look into the details, it seems that for 
> those that are requiring the quirk HID_QUIRK_NO_INIT_REPORTS, the driver 
> fails to retrieve part of the features/inputs while others (more 
> generic) work.
> 
> IMO, it should be acceptable to remove the need for the quirk in the 
> general case. On the small amount of cases where we actually need to 
> read the current values, the driver in charge (hid-mt or wacom) already 
> retrieves the features manually.

Applied to for-4.12/nuke-no-init-reports-quirk. Thanks,

-- 
Jiri Kosina
SUSE Labs