linux-kernel - Re: [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2017 11:56:58 +0900
From:   Byungchul Park <byungchul.park@....com>
To:     peterz@...radead.org, mingo@...nel.org
Cc:     peterz@...radead.org, mingo@...nel.org,
        linux-kernel@...r.kernel.org, juri.lelli@...il.com,
        rostedt@...dmis.org, kernel-team@....com,
        Daniel Bristot de Oliveira <bristot@...hat.com>
Subject: Re: [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in
 push_dl_task()

On Thu, Feb 16, 2017 at 06:35:54PM +0100, Daniel Bristot de Oliveira wrote:
> On 02/16/2017 03:34 AM, Byungchul Park wrote:
> > pick_next_pushable_dl_task(rq) has BUG_ON(rq->cpu != task_cpu(task))
> > when it returns a task other than NULL, which means that task_cpu(task)
> > must be rq->cpu. So if task == next_task, then task_cpu(next_task) must
> > be rq->cpu as well. Remove the redundant condition and make code simpler.
> > 
> > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > statement can be avoided.
> > 
> > Signed-off-by: Byungchul Park <byungchul.park@....com>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> > Reviewed-by: Juri Lelli <juri.lelli@....com>
> 
> +1
> 
> Reviewed-by: Daniel Bristot de Oliveira <bristot@...hat.com>

Hello,

Could you check this out?

> 
> -- Daniel