linux-kernel - [PATCH] gen_init_cpio: allocate enough space for dname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2017 16:44:39 +0000
From:   Colin King <colin.king@...onical.com>
To:     kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: [PATCH] gen_init_cpio: allocate enough space for dname

From: Colin Ian King <colin.king@...onical.com>

The allocation of dname is short by 1 byte, so increase the allocation
size.

Detected with CoverityScan, CID#711628 ("Out-of-bounds-access (OVERRUN)")

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 usr/gen_init_cpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c
index 225ad244cf88..981682f4faea 100644
--- a/usr/gen_init_cpio.c
+++ b/usr/gen_init_cpio.c
@@ -418,7 +418,7 @@ static int cpio_mkfile_line(const char *line)
 		int len;
 		int nend;
 
-		dname = malloc(strlen(line));
+		dname = malloc(strlen(line) + 1);
 		if (!dname) {
 			fprintf (stderr, "out of memory (%d)\n", dname_len);
 			goto fail;
-- 
2.11.0