linux-kernel - Re: [PATCH] pci-error-recovery: doc cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Mar 2017 13:48:51 +0800
From:   Linas Vepstas <linasvepstas@...il.com>
To:     Cao jin <caoj.fnst@...fujitsu.com>
Cc:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        linux-doc@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH] pci-error-recovery: doc cleanup

Hi,

On Tue, Mar 21, 2017 at 9:24 PM, Cao jin <caoj.fnst@...fujitsu.com> wrote:
> Include whitespace shooting; correction; typo fix; superfluous word
> dropping.

>
> diff --git a/Documentation/PCI/pci-error-recovery.txt b/Documentation/PCI/pci-error-recovery.txt
> index da3b217..0b6bb3e 100644
> --- a/Documentation/PCI/pci-error-recovery.txt
> +++ b/Documentation/PCI/pci-error-recovery.txt
>
> @@ -231,14 +231,14 @@ proceeds to STEP 4 (Slot Reset)
>  STEP 3: Link Reset
>  ------------------
>  The platform resets the link.  This is a PCI-Express specific step
> -and is done whenever a non-fatal error has been detected that can be
> +and is done whenever a fatal error has been detected that can be
>  "solved" by resetting the link.

First: I thought I saw a patch a few months ago that proposed removing
the link rest step.  I don't know if the patch was accepted or not.

If link resets are still supported, then they can only fix NON-fatal errors:
basically, one resets the link, and only the link; one does NOT reset
either the device driver, nor the device state. The idea is that after a link
reset, communications with the device can immediately resume right
where it left off. (this can be hard in practice, if the driver/firmware doesn't
know what it was doing when the error occurred.  this might be why no one
implements it.)  Anyway, the whole point of a link reset is that it is
explicitly
a non-fatal error.

--linas