linux-kernel - Re: [PATCH 6/6 v3] ftrace/x86: Use Makefile logic instead of #ifdef of compling ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2017 17:56:43 -0700
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...capital.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 6/6 v3] ftrace/x86: Use Makefile logic instead of #ifdef
 of compling ftrace_*.o

On Mon, 20 Mar 2017 09:04:25 -0500
Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> On Sat, Mar 18, 2017 at 05:09:29PM -0400, Steven Rostedt wrote:
> > From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> > 
> > Currently ftrace_32.S and ftrace_64.S are compiled even when
> > CONFIG_FUNCTION_TRACER is not set. This means there's an
> > unnecessary #ifdef to protect the code. Instead of using
> > preprocessor directives, only compile those files when
> > FUNCTION_TRACER is defined.
> > 
> > Link:
> > http://lkml.kernel.org/r/20170316210043.peycxdxktwwn6cid@treble
> > Suggested-by: Josh Poimboeuf <jpoimboe@...hat.com> Signed-off-by:
> > Steven Rostedt (VMware) <rostedt@...dmis.org>  
> 
> The subject has a typo ("compling") and would parse better if the
> second "of" where changed to a "for": "for compiling".  Otherwise:

But this was to comply with #ifdef of ftrace_*.o!

;-)

> 
> Reviewed-by: Josh Poimboeuf <jpoimboe@...hat.com>
> 

Thanks!

-- Steve