linux-kernel - Re: [PATCH] scsi: lpfc: fix linking against modular NVMe support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2017 19:25:22 -0700
From:   James Smart <james.smart@...adcom.com>
To:     Arnd Bergmann <arnd@...db.de>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Hannes Reinecke <hare@...e.de>,
        Finn Thain <fthain@...egraphics.com.au>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        James Smart <jsmart2021@...il.com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: fix linking against modular NVMe support

Note: the patch I referenced 
(http://www.spinics.net/lists/linux-scsi/msg106102.html) replaced the 
one I think you referenced below 
(http://www.spinics.net/lists/linux-scsi/msg106024.html)

-- james


On 3/21/2017 7:23 PM, James Smart wrote:
> Arnd,
>
> All of the build issues, including building as modules, should have 
> been resolved by the following patch:
> http://www.spinics.net/lists/linux-scsi/msg106102.html
>
> Am I missing something ?
>
> -- james
>
>
> On 3/21/2017 6:09 AM, Arnd Bergmann wrote:
>> When LPFC is built-in but NVMe is a loadable module, we fail to
>> link the kernel:
>>
>> drivers/scsi/built-in.o: In function `lpfc_nvme_create_localport':
>> (.text+0x156a82): undefined reference to `nvme_fc_register_localport'
>> drivers/scsi/built-in.o: In function `lpfc_nvme_destroy_localport':
>> (.text+0x156eaa): undefined reference to `nvme_fc_unregister_remoteport'
>>
>> We can avoid this either by forcing lpfc to be a module, or by disabling
>> NVMe support in this case. This implements the former.
>>
>> Fixes: 7d7080335f8d ("scsi: lpfc: Finalize Kconfig options for nvme")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>   drivers/scsi/Kconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
>> index 3c52867dfe28..d145e0d90227 100644
>> --- a/drivers/scsi/Kconfig
>> +++ b/drivers/scsi/Kconfig
>> @@ -1241,6 +1241,8 @@ config SCSI_LPFC
>>       tristate "Emulex LightPulse Fibre Channel Support"
>>       depends on PCI && SCSI
>>       depends on SCSI_FC_ATTRS
>> +    depends on NVME_TARGET_FC || NVME_TARGET_FC=n
>> +    depends on NVME_FC || NVME_FC=n
>>       select CRC_T10DIF
>>       ---help---
>>             This lpfc driver supports the Emulex LightPulse
>