lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 23 Mar 2017 04:38:38 -0400
From:   Mark Stenglein <mark@...ngle.in>
To:     gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Mark Stenglein <mark@...ngle.in>
Subject: [PATCH] staging: most: Adds parentheses around macros with complex values

Fixes three instances of the following checklist error:
    - ERROR: Macros with complex values should be enclosed
      in parentheses

Simply adds parentheses around the macros to fix the problem.

Signed-off-by: Mark Stenglein <mark@...ngle.in>
---
 drivers/staging/most/mostcore/core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
index 191404bc5906..13e65f149d68 100644
--- a/drivers/staging/most/mostcore/core.c
+++ b/drivers/staging/most/mostcore/core.c
@@ -341,8 +341,8 @@ static ssize_t show_channel_starving(struct most_c_obj *c,
 	return snprintf(buf, PAGE_SIZE, "%d\n", c->is_starving);
 }
 
-#define create_show_channel_attribute(val) \
-	static MOST_CHNL_ATTR(val, 0444, show_##val, NULL)
+#define(create_show_channel_attribute(val)          \
+	static MOST_CHNL_ATTR(val, 0444, show_##val, NULL))
 
 create_show_channel_attribute(available_directions);
 create_show_channel_attribute(available_datatypes);
@@ -493,8 +493,8 @@ static ssize_t store_set_packets_per_xact(struct most_c_obj *c,
 	return count;
 }
 
-#define create_channel_attribute(value) \
-	static MOST_CHNL_ATTR(value, 0644, show_##value, store_##value)
+#define(create_channel_attribute(value) \
+	static MOST_CHNL_ATTR(value, 0644, show_##value, store_##value))
 
 create_channel_attribute(set_buffer_size);
 create_channel_attribute(set_number_of_buffers);
@@ -687,8 +687,8 @@ static ssize_t show_interface(struct most_inst_obj *instance_obj,
 	return snprintf(buf, PAGE_SIZE, "unknown\n");
 }
 
-#define create_inst_attribute(value) \
-	static MOST_INST_ATTR(value, 0444, show_##value, NULL)
+#define(create_inst_attribute(value) \
+	static MOST_INST_ATTR(value, 0444, show_##value, NULL))
 
 create_inst_attribute(description);
 create_inst_attribute(interface);
-- 
2.12.1


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ