linux-kernel - Re: [PATCH 05/11] staging: speakup: Remove multiple assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2017 14:18:42 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     w.d.hubbs@...il.com, devel@...verdev.osuosl.org, kirk@...sers.ca,
        speakup@...ux-speakup.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com, samuel.thibault@...-lyon.org,
        chris@...-brannons.com
Subject: Re: [PATCH 05/11] staging: speakup: Remove multiple assignments

On Tue, Mar 21, 2017 at 05:12:29PM +0530, Arushi Singhal wrote:
> This patch fixes the checkpatch.pl warning "multiple assignments
> should be avoided."
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> ---
>  drivers/staging/speakup/main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index 21e76b031449..c10445624e92 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -2106,7 +2106,8 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
>  			spk_keydown = 0;
>  			goto out;
>  		}
> -		value = spk_lastkey = pad_chars[value];
> +		value = pad_chars[value];
> +		spk_lastkey = value;

Also harder to read now :(