linux-kernel - Re: [PATCH] x86/syscalls/32: ignore arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2017 11:59:11 -0700
From:   Kyle Huey <me@...ehuey.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Kyle Huey <khuey@...ehuey.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/syscalls/32: ignore arch_prctl for other architectures

On Thu, Mar 23, 2017 at 8:18 AM, Arnd Bergmann <arnd@...db.de> wrote:
> sys_arch_prctl is only provided on x86, and there is no reason
> to add it elsewhere. However, including it on the 32-bit syscall
> table caused a warning for most configurations on non-x86:
>
> :1328:2: warning: #warning syscall arch_prctl not implemented [-Wcpp]
>
> This adds an exception to the syscall table checking script.
>
> Fixes: 79170fda313e ("x86/syscalls/32: Wire up arch_prctl on x86-32")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  scripts/checksyscalls.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> Thomas, can you apply this on top of the x86 patch?
>
> diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
> index f7ad07128811..0cce56da3706 100755
> --- a/scripts/checksyscalls.sh
> +++ b/scripts/checksyscalls.sh
> @@ -148,6 +148,7 @@ cat << EOF
>  #define __IGNORE_sysfs
>  #define __IGNORE_uselib
>  #define __IGNORE__sysctl
> +#define __IGNORE_arch_prctl
>
>  /* ... including the "new" 32-bit uid syscalls */
>  #define __IGNORE_lchown32
> --
> 2.9.0
>

Ah, nice. lgtm.

- Kyle