linux-kernel - Re: [PATCH v2 3/3] Input: qt1070

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2017 14:45:59 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table

On Thu, Mar 23, 2017 at 04:14:56PM -0300, Javier Martinez Canillas wrote:
> Hello Dmitry,
> 
> On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote:
> > The driver doesn't have a struct of_device_id table but supported devices
> > are registered via Device Trees. This is working on the assumption that a
> > I2C device registered via OF will always match a legacy I2C device ID and
> > that the MODALIAS reported will always be of the form i2c:<device>.
> > 
> > But this could change in the future so the correct approach is to have an
> > OF device ID table if the devices are registered via OF.
> > 
> > The compatible strings don't have a vendor prefix because that's how it's
> > used currently, and changing this will be a Device Tree ABI break.
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> > ---
> > 
> 
> What's your decision about this patch series?

OK, I queued them for -next. Could you also make a patch to update
binding docs for silead?

Thanks!

-- 
Dmitry