linux-kernel - Re: [PATCH v5 2/5] perf report: Find the inline stack for a given address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 25 Mar 2017 20:45:04 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>, acme@...nel.org
Cc:     jolsa@...nel.org, Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, milian.wolff@...b.com, yao.jin@...el.com
Subject: Re: [PATCH v5 2/5] perf report: Find the inline stack for a given
 address

Hi Ravi, Arnaldo,

The build error happens when BFD lib is not set in build environment.

Anyway the patch series should be improved to get better compatibility 
for this case. For easy patch management, I send the v6 patch series for 
fixing this issue. Very sorry for the inconvenience.

Thanks

Jin Yao


On 3/25/2017 3:18 PM, Ravi Bangoria wrote:
> Hi Jin / Arnaldo,
>
> I see a build failure with this patch:
>
> On Friday 17 March 2017 03:12 AM, Jin Yao wrote:
>> It would be useful for perf to support a mode to query the
>> inline stack for a given callgraph address. This would simplify
>> finding the right code in code that does a lot of inlining.
>>
>> The srcline.c has contained the code which supports to translate
>> the address to filename:line_nr. This patch just extends the
>> function to let it support getting the inline stacks.
> ...
>> +	while (getline(&filename, &len, fp) != -1) {
>> +		if (filename_split(filename, &line_nr) != 1) {
>> +			free(filename);
>> +			goto out;
>> +		}
>> +
>> +		if (inline_list__append(filename, NULL, line_nr, node) != 0)
> util/srcline.c: In function ‘addr2inlines’:
> util/srcline.c:403:7: error: too few arguments to function ‘inline_list__append’
>     if (inline_list__append(filename, NULL, line_nr, node) != 0)
>         ^
> util/srcline.c:34:12: note: declared here
>   static int inline_list__append(char *filename, char *funcname, int line_nr,
>              ^
> util/srcline.c: At top level:
> util/srcline.c:60:13: error: ‘inline_list__reverse’ defined but not used [-Werror=unused-function]
>   static void inline_list__reverse(struct inline_node *node)
>               ^
> cc1: all warnings being treated as errors
> mv: cannot stat ‘util/.srcline.o.tmp’: No such file or directory
>
> Thanks,
> Ravi
>