linux-kernel - Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Mar 2017 15:10:29 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, Kishon Vijay Abraham I <kishon@...com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        Marcel Partap <mpartap@....net>,
        Michael Scott <michael.scott@...aro.org>
Subject: Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

* kbuild test robot <lkp@...el.com> [170325 13:45]:
> Hi Tony,
> 
> [auto build test ERROR on phy/next]
> [also build test ERROR on v4.11-rc3 next-20170324]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Tony-Lindgren/phy-cpcap-usb-Add-CPCAP-PMIC-USB-support/20170324-061112
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git next
> config: x86_64-randconfig-a0-03260238 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/built-in.o: In function `cpcap_usb_detect':
> >> phy-cpcap-usb.c:(.text+0x18ad): undefined reference to `iio_read_channel_processed'
>    drivers/built-in.o: In function `cpcap_usb_phy_probe':
> >> phy-cpcap-usb.c:(.text+0x1c5e): undefined reference to `devm_iio_channel_get'
> >> phy-cpcap-usb.c:(.text+0x1c92): undefined reference to `iio_get_channel_type'

OK thanks for the report, we need IIO for VBUS level, here's
a patch to fix it.

Regards,

Tony

8< -----------------------
>From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@...mide.com>
Date: Sat, 25 Mar 2017 15:04:37 -0700
Subject: [PATCH] phy: cpcap-usb: Fix build by adding a dependency to
 CONFIG_IIO

We need the ADC output provided by IIO to detect VBUS level.
Otherwise we can get:

drivers/built-in.o: In function `cpcap_usb_detect':
phy-cpcap-usb.c:(.text+0x18ad): undefined reference to
`iio_read_channel_processed'
drivers/built-in.o: In function `cpcap_usb_phy_probe':
phy-cpcap-usb.c:(.text+0x1c5e): undefined reference to
`devm_iio_channel_get'
phy-cpcap-usb.c:(.text+0x1c92): undefined reference to`iio_get_channel_type'

Reported-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Tony Lindgren <tony@...mide.com>
---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -49,7 +49,7 @@ config PHY_BERLIN_SATA
 
 config PHY_CPCAP_USB
 	tristate "CPCAP USB PHY driver"
-	depends on USB_SUPPORT
+	depends on USB_SUPPORT && IIO
 	select GENERIC_PHY
 	select USB_PHY
 	help
-- 
2.12.1