lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Mar 2017 20:05:46 -0700 (PDT) From: David Miller <davem@...emloft.net> To: arnd@...db.de Cc: dledford@...hat.com, oulijun@...wei.com, xavier.huwei@...wei.com, huangdaode@...ilicon.com, yankejian@...wei.com, xieqianqian@...wei.com, weiyongjun1@...wei.com, yisen.zhuang@...wei.com, salil.mehta@...wei.com, sean.hefty@...el.com, hal.rosenstock@...il.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [RESEND PATCH 1/3] net: hns: fix uninitialized data use From: Arnd Bergmann <arnd@...db.de> Date: Fri, 24 Mar 2017 23:02:49 +0100 > When dev_dbg() is enabled, we print uninitialized data, as gcc-7.0.1 > now points out: > > ethernet/hisilicon/hns/hns_dsaf_main.c: In function 'hns_dsaf_set_promisc_tcam': > ethernet/hisilicon/hns/hns_dsaf_main.c:2947:75: error: 'tbl_tcam_data.low.val' may be used uninitialized in this function [-Werror=maybe-uninitialized] > ethernet/hisilicon/hns/hns_dsaf_main.c:2947:75: error: 'tbl_tcam_data.high.val' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > We also pass the data into hns_dsaf_tcam_mc_cfg(), which might later > use it (not sure about that), so it seems safer to just always initialize > the tbl_tcam_data structure. > > Fixes: 1f5fa2dd1cfa ("net: hns: fix for promisc mode in HNS driver") > Signed-off-by: Arnd Bergmann <arnd@...db.de> Applied.
Powered by blists - more mailing lists