linux-kernel - Re: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2017 13:39:43 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     cristian.birsan@...rochip.com, nicolas.ferre@...el.com,
        gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     ludovic.desroches@...el.com, alexandre.belloni@...e-electrons.com,
        boris.brezillon@...e-electrons.com,
        Cristian Birsan <cristian.birsan@...rochip.com>
Subject: Re: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error


Hi,

cristian.birsan@...rochip.com writes:
> From: Cristian Birsan <cristian.birsan@...rochip.com>
>
> Use dev_warn() to display EP configuration error to avoid silent failure.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@...rochip.com>
> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 2bd8410..942c9c9 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1851,7 +1851,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
>  		 * but it's clearly harmless...
>  		 */
>  		if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED))
> -			dev_dbg(&udc->pdev->dev,
> +			dev_warn(&udc->pdev->dev,

seems like dev_err() would've been more fitting.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)