linux-kernel - Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2017 14:54:42 +0200
From:   Willy TARREAU <wtarreau@...roxy.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder

On Thu, Mar 30, 2017 at 02:27:06PM +0300, Andy Shevchenko wrote:
> On Mon, 2017-03-27 at 11:01 +0200, Willy TARREAU wrote:
> > On Mon, Mar 27, 2017 at 10:26:07AM +0200, Geert Uytterhoeven wrote:
> > > On Mon, Mar 27, 2017 at 10:11 AM, Willy TARREAU <wtarreau@...roxy.co
> > > m> wrote:
> > > > On Fri, Mar 24, 2017 at 04:19:43PM +0100, Geert Uytterhoeven
> > > > wrote:
> > > > > On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko
> > > > > <andriy.shevchenko@...ux.intel.com> wrote:
> > > > > > On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote:
> > > > > > > On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko
> > > > > > > <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > In fact here the output signals should be seen as a shared bus with
> > multiple
> > chip select signals. Note that in some designs it's even possible that
> > pressing
> > multiple buttons will cause crap to be sent to the LCD by short-
> > circuiting
> > the lines (if no diodes are used) but it might be acceptable for many
> > designs,
> > especially the DIY field where the principle is "don't do it".
> 
> So, summarizing the comments are we okay to proceed or there is a clear
> objection?

I don't know all the impacts, but as long as it continues to work I'm
totally fine with seeing the code being changed and refactored. It
already got a nice improvement with this series. Furthermore I can
occasionally give it a try if that helps :-)

Willy