linux-kernel - Re: [PATCH RESEND 2/2] pidns: Expose task pid_ns_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2017 18:04:10 -0700
From:   Andrei Vagin <avagin@...tuozzo.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     Kirill Tkhai <ktkhai@...tuozzo.com>, <agruenba@...hat.com>,
        <keescook@...omium.org>, <linux-api@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <viro@...iv.linux.org.uk>,
        <oleg@...hat.com>, <paul@...l-moore.com>, <ebiederm@...ssion.com>,
        <avagin@...nvz.org>, <linux-fsdevel@...r.kernel.org>,
        <mtk.manpages@...il.com>, <luto@...capital.net>,
        <mingo@...nel.org>, <serge@...lyn.com>
Subject: Re: [PATCH RESEND 2/2] pidns: Expose task pid_ns_for_children to
 userspace

On Thu, Mar 30, 2017 at 03:05:20PM -0700, Andrew Morton wrote:
> On Thu, 30 Mar 2017 13:27:59 +0300 Kirill Tkhai <ktkhai@...tuozzo.com> wrote:
> 
> > pid_ns_for_children set by a task is known only to the task itself,
> > and it's impossible to identify it from outside.
> > 
> > It's a big problem for checkpoint/restore software like CRIU,
> > because it can't correctly handle tasks, that do setns(CLONE_NEWPID)
> > in proccess of their work.
> > 
> > This patch solves the problem, and it exposes pid_ns_for_children
> > to ns directory in standard way with the name "pid_for_children":
> > 
> > ~# ls /proc/5531/ns -l | grep pid
> > lrwxrwxrwx 1 root root 0 Jan 14 16:38 pid -> pid:[4026531836]
> > lrwxrwxrwx 1 root root 0 Jan 14 16:38 pid_for_children -> pid:[4026532286]
> > 
> > --- a/fs/proc/namespaces.c
> > +++ b/fs/proc/namespaces.c
> > @@ -23,6 +23,7 @@ static const struct proc_ns_operations *ns_entries[] = {
> >  #endif
> >  #ifdef CONFIG_PID_NS
> >  	&pidns_operations,
> > +	&pidns_for_children_operations,
> >  #endif
> 
> This interface should be documented somewhere under Documentation/. 
> But I can't immediately find where the /proc/pid/ns/ pseudo-files are
> documented...

I know that they are documented in man7/namespaces.7

https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/man7/namespaces.7#n187

> 
>