lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Mar 2017 11:24:19 +0800 From: Zhen Lei <thunder.leizhen@...wei.com> To: Joerg Roedel <joro@...tes.org>, iommu <iommu@...ts.linux-foundation.org>, Robin Murphy <robin.murphy@....com>, David Woodhouse <dwmw2@...radead.org>, Sudeep Dutt <sudeep.dutt@...el.com>, Ashutosh Dixit <ashutosh.dixit@...el.com>, linux-kernel <linux-kernel@...r.kernel.org> CC: Zefan Li <lizefan@...wei.com>, Xinwei Hu <huxinwei@...wei.com>, "Tianhong Ding" <dingtianhong@...wei.com>, Hanjun Guo <guohanjun@...wei.com>, Zhen Lei <thunder.leizhen@...wei.com> Subject: [PATCH v2 1/7] iommu/iova: fix incorrect variable types Keep these four variables type consistent with the paramters of function __alloc_and_insert_iova_range and the members of struct iova: 1. static int __alloc_and_insert_iova_range(struct iova_domain *iovad, unsigned long size, unsigned long limit_pfn, 2. struct iova { unsigned long pfn_hi; unsigned long pfn_lo; In fact, limit_pfn is most likely larger than 32 bits on DMA64. Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com> --- drivers/iommu/iova.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c index b7268a1..8ba8b496 100644 --- a/drivers/iommu/iova.c +++ b/drivers/iommu/iova.c @@ -104,8 +104,8 @@ __cached_rbnode_delete_update(struct iova_domain *iovad, struct iova *free) * Computes the padding size required, to make the start address * naturally aligned on the power-of-two order of its size */ -static unsigned int -iova_get_pad_size(unsigned int size, unsigned int limit_pfn) +static unsigned long +iova_get_pad_size(unsigned long size, unsigned long limit_pfn) { return (limit_pfn + 1 - size) & (__roundup_pow_of_two(size) - 1); } @@ -117,7 +117,7 @@ static int __alloc_and_insert_iova_range(struct iova_domain *iovad, struct rb_node *prev, *curr = NULL; unsigned long flags; unsigned long saved_pfn; - unsigned int pad_size = 0; + unsigned long pad_size = 0; /* Walk the tree backwards */ spin_lock_irqsave(&iovad->iova_rbtree_lock, flags); -- 2.5.0
Powered by blists - more mailing lists