linux-kernel - Re: [PATCH] iio: light: bh1750: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 1 Apr 2017 11:31:41 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     simran singhal <singhalsimran0@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: light: bh1750: constify attribute_group structures

On 01/04/17 09:33, simran singhal wrote:
> Check for attribute_group structures that are only stored in the
> attrs filed of iio_info structure. As the attrs field of iio_info
> structures is constant, so these attribute_group structures can also be
> declared constant.
> Done using coccinelle:
> 
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct attribute_group i@p = {...};
> 
> @ok1@
> identifier r1.i;
> position p;
> struct iio_info x;
> @@
> x.attrs=&i@p;
> 
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> static
> +const
> struct attribute_group i={...};
> 
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct attribute_group i;
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    2276	    352	      0	   2628	    a44	drivers/iio/light/bh1750.o
> 
> File size after:
>    text	   data	    bss	    dec	    hex	filename
>    2340	    320	      0	   2660	    a64	drivers/iio/light/bh1750.o
> 
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
(I'll get lazy in a mo and just put applied ;)

Jonathan
> ---
>  drivers/iio/light/bh1750.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c
> index b059466..6c61187 100644
> --- a/drivers/iio/light/bh1750.c
> +++ b/drivers/iio/light/bh1750.c
> @@ -212,7 +212,7 @@ static struct attribute *bh1750_attributes[] = {
>  	NULL,
>  };
>  
> -static struct attribute_group bh1750_attribute_group = {
> +static const struct attribute_group bh1750_attribute_group = {
>  	.attrs = bh1750_attributes,
>  };
>  
>