linux-kernel - Re: [PATCH v13 3/6] mmc: cavium: Add MMC PCI driver for ThunderX SOCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 1 Apr 2017 14:47:48 +0200
From:   Jan Glauber <jan.glauber@...iumnetworks.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, Ulf Hansson <ulf.hansson@...aro.org>,
        David Daney <david.daney@...ium.com>,
        "Steven J . Hill" <steven.hill@...ium.com>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 3/6] mmc: cavium: Add MMC PCI driver for ThunderX SOCs

On Sat, Apr 01, 2017 at 12:46:16PM +0800, kbuild test robot wrote:
> Hi Jan,
> 
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.11-rc4 next-20170331]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Jan-Glauber/Cavium-MMC-driver/20170401-055302
> config: sparc64-allmodconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=sparc64 
> 
> All errors (new ones prefixed by >>):
> 
> >> ERROR: "of_platform_device_create" [drivers/mmc/host/thunderx-mmc.ko] undefined!
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

commit d431e1fd494546795ab6478dece96532106b5e62
Author: Jan Glauber <jglauber@...ium.com>
Date:   Sat Apr 1 14:43:51 2017 +0200

    mmc: thunderx: Make driver depend on OF_ADDRESS
    
    Prevent this compile error (COMPILE_TEST) on sparc64:
    >> ERROR: "of_platform_device_create" [drivers/mmc/host/thunderx-mmc.ko] undefined!
    
    Signed-off-by: Jan Glauber <jglauber@...ium.com>

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index c882795..c2d05ba 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -626,6 +626,7 @@ config MMC_CAVIUM_THUNDERX
 	tristate "Cavium ThunderX SD/MMC Card Interface support"
 	depends on PCI && 64BIT && (ARM64 || COMPILE_TEST)
 	depends on GPIOLIB
+	depends on OF_ADDRESS
 	help
 	  This selects Cavium ThunderX SD/MMC Card Interface.
 	  If you have an Cavium ARM64 board with a Multimedia Card slot