linux-kernel - Re: [PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 2 Apr 2017 09:52:50 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     simran singhal <singhalsimran0@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void
 pointer

On 01/04/17 15:18, simran singhal wrote:
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> - (T*)
>   e
> )
> 
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
Applied and pushed out as testing as normal.

Thanks for these. Good to clean them up. It's one of my pet
hates, but still the sometimes get through ;)

Jonathan
> ---
>  drivers/iio/pressure/zpa2326.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
> index c720c3a..e58a0ad 100644
> --- a/drivers/iio/pressure/zpa2326.c
> +++ b/drivers/iio/pressure/zpa2326.c
> @@ -751,7 +751,7 @@ static void zpa2326_suspend(struct iio_dev *indio_dev)
>   */
>  static irqreturn_t zpa2326_handle_irq(int irq, void *data)
>  {
> -	struct iio_dev *indio_dev = (struct iio_dev *)data;
> +	struct iio_dev *indio_dev = data;
>  
>  	if (iio_buffer_enabled(indio_dev)) {
>  		/* Timestamping needed for buffered sampling only. */
> @@ -790,7 +790,7 @@ static irqreturn_t zpa2326_handle_irq(int irq, void *data)
>   */
>  static irqreturn_t zpa2326_handle_threaded_irq(int irq, void *data)
>  {
> -	struct iio_dev         *indio_dev = (struct iio_dev *)data;
> +	struct iio_dev         *indio_dev = data;
>  	struct zpa2326_private *priv = iio_priv(indio_dev);
>  	unsigned int            val;
>  	bool                    cont;
>