linux-kernel - Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2017 10:20:28 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     kbuild test robot <lkp@...el.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        kbuild-all@...org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linus Walleij <linus.walleij@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>
Subject: Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation
 units

On Sun, 02 Apr 2017, Andy Shevchenko wrote:

> On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@...el.com> wrote:
> > Hi Andy,
> >
> > [auto build test ERROR on ljones-mfd/for-mfd-next]
> > [also build test ERROR on v4.11-rc4 next-20170331]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> Thank you for report, though...
> 
> >
> > url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/mfd-intel_soc_pmic-Fix-a-mess-with-compilation-units/20170320-153539
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> > config: tile-allyesconfig (attached as .config)
> > compiler: tilegx-linux-gcc (GCC) 4.6.2
> > reproduce:
> >         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> 
> >         make.cross ARCH=tile
> 
> ...I doubt how below is related to my patch. This is obvious x86 code
> which was initially submitted without
> depend on X86
> line in corresponding Kconfig.

I think you should probably specify the architecture in the Kconfig
entry, or else some `randconfig`s will fail.

> > All errors (new ones prefixed by >>):
> >
> >>> drivers/mfd/intel_soc_pmic_bxtwc.c:24:31: fatal error: asm/intel_pmc_ipc.h: No such file or directory
> >    compilation terminated.
> >
> > vim +24 drivers/mfd/intel_soc_pmic_bxtwc.c
> >
> > 39d047c0 Qipeng Zha 2015-09-15   8   * version 2, as published by the Free Software Foundation.
> > 39d047c0 Qipeng Zha 2015-09-15   9   *
> > 39d047c0 Qipeng Zha 2015-09-15  10   * This program is distributed in the hope it will be useful, but WITHOUT
> > 39d047c0 Qipeng Zha 2015-09-15  11   * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> > 39d047c0 Qipeng Zha 2015-09-15  12   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> > 39d047c0 Qipeng Zha 2015-09-15  13   * more details.
> > 39d047c0 Qipeng Zha 2015-09-15  14   */
> > 39d047c0 Qipeng Zha 2015-09-15  15
> > 39d047c0 Qipeng Zha 2015-09-15  16  #include <linux/module.h>
> > 39d047c0 Qipeng Zha 2015-09-15  17  #include <linux/acpi.h>
> > 39d047c0 Qipeng Zha 2015-09-15  18  #include <linux/err.h>
> > 39d047c0 Qipeng Zha 2015-09-15  19  #include <linux/delay.h>
> > 39d047c0 Qipeng Zha 2015-09-15  20  #include <linux/interrupt.h>
> > 39d047c0 Qipeng Zha 2015-09-15  21  #include <linux/kernel.h>
> > 39d047c0 Qipeng Zha 2015-09-15  22  #include <linux/mfd/core.h>
> > 39d047c0 Qipeng Zha 2015-09-15  23  #include <linux/mfd/intel_bxtwc.h>
> > 39d047c0 Qipeng Zha 2015-09-15 @24  #include <asm/intel_pmc_ipc.h>
> > 39d047c0 Qipeng Zha 2015-09-15  25
> > 39d047c0 Qipeng Zha 2015-09-15  26  /* PMIC device registers */
> > 39d047c0 Qipeng Zha 2015-09-15  27  #define REG_ADDR_MASK               0xFF00
> > 39d047c0 Qipeng Zha 2015-09-15  28  #define REG_ADDR_SHIFT              8
> > 39d047c0 Qipeng Zha 2015-09-15  29  #define REG_OFFSET_MASK             0xFF
> > 39d047c0 Qipeng Zha 2015-09-15  30
> > 39d047c0 Qipeng Zha 2015-09-15  31  /* Interrupt Status Registers */
> > 39d047c0 Qipeng Zha 2015-09-15  32  #define BXTWC_IRQLVL1               0x4E02
> >
> > :::::: The code at line 24 was first introduced by commit
> > :::::: 39d047c0b1c812e9f0014e7100e372e61f2de3de mfd: add Intel Broxton Whiskey Cove PMIC driver
> >
> > :::::: TO: Qipeng Zha <qipeng.zha@...el.com>
> > :::::: CC: Lee Jones <lee.jones@...aro.org>
> >
> > ---
> > 0-DAY kernel test infrastructure                Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
> 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog