linux-kernel - Re: [PATCH 9/9] [media] cx231xx: stop double error reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2017 12:26:46 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Peter Rosin <peda@...ntia.se>
Cc:     linux-kernel@...r.kernel.org,
        Peter Korsgaard <peter.korsgaard@...co.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-i2c@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 9/9] [media] cx231xx: stop double error reporting

On Mon, Apr 03, 2017 at 10:38:38AM +0200, Peter Rosin wrote:
> i2c_mux_add_adapter already logs a message on failure.
> 
> Signed-off-by: Peter Rosin <peda@...ntia.se>
> ---
>  drivers/media/usb/cx231xx/cx231xx-i2c.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c
> index 35e9acfe63d3..dff514e147da 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c
> @@ -576,17 +576,10 @@ int cx231xx_i2c_mux_create(struct cx231xx *dev)
>  
>  int cx231xx_i2c_mux_register(struct cx231xx *dev, int mux_no)
>  {
> -	int rc;
> -
> -	rc = i2c_mux_add_adapter(dev->muxc,
> -				 0,
> -				 mux_no /* chan_id */,
> -				 0 /* class */);
> -	if (rc)
> -		dev_warn(dev->dev,
> -			 "i2c mux %d register FAILED\n", mux_no);
> -
> -	return rc;
> +	return i2c_mux_add_adapter(dev->muxc,
> +				   0,
> +				   mux_no /* chan_id */,
> +				   0 /* class */);

Could be argued that the whole function is obsolete now and the
c231xx-core can call i2c_mux_add_adapter() directly. But maybe this is a
seperate patch.

>  }
>  
>  void cx231xx_i2c_mux_unregister(struct cx231xx *dev)
> -- 
> 2.1.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)