linux-kernel - [PATCH v1] reset: Make optional stuff optional for all users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  3 Apr 2017 15:26:38 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Philipp Zabel <p.zabel@...gutronix.de>,
        linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>
Subject: [PATCH v1] reset: Make optional stuff optional for all users

There is Device Tree oriented check for optional resource. Of course
it will fail on non-DT platforms.

Remove this check to make things optional for all users.

Fixes: bb475230b8e5 ("reset: make optional functions really optional")
Cc: Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
---

 The reset framework is too Device Tree oriented, and who knows what
 the logic was behind the commit which introduced devm_reset_*()
 functions without thinking out of the DT box.

 This commit fixes almost all Intel newest boards that have no legacy
 UART since UART driver started using this DT-centric framework.

 drivers/reset/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index f1e5e65388bb..62314e663f29 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -331,9 +331,6 @@ struct reset_control *__of_reset_control_get(struct device_node *node,
 	int rstc_id;
 	int ret;

-	if (!node)
-		return ERR_PTR(-EINVAL);
-
 	if (id) {
 		index = of_property_match_string(node,
 						 "reset-names", id);
-- 
2.11.0