linux-kernel - Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2017 09:43:50 +0530
From:   Prasant Jalan <prasant.jalan@...il.com>
To:     Larry.Finger@...inger.net
Cc:     Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg KH <gregkh@...uxfoundation.org>, geliangtang@....com,
        raphael.beamonte@...il.com, vijaikumar.kanagarajan@...il.com,
        Souptick Joarder <jrdr.linux@...il.com>,
        driverdevel <devel@...verdev.osuosl.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Prasant Jalan <prasant.jalan@...il.com>
Subject: Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.jalan@...il.com> wrote:
> Checkpatch emits WARNING: Avoid multiple line dereference.
>
> Trivial indentation improvement helps fix the checkpatch warning.
>
> Signed-off-by: Prasant Jalan <prasant.jalan@...il.com>
> ---
>  drivers/staging/rtl8712/rtl871x_xmit.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> index de88819..10edf00 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> @@ -213,8 +213,9 @@ sint r8712_update_attrib(struct _adapter *padapter, _pkt *pkt,
>                 if (padapter->pwrctrlpriv.pwr_mode !=
>                     padapter->registrypriv.power_mgnt) {
>                         del_timer_sync(&pmlmepriv->dhcp_timer);
> -                       r8712_set_ps_mode(padapter, padapter->registrypriv.
> -                               power_mgnt, padapter->registrypriv.smart_ps);
> +                       r8712_set_ps_mode(padapter,
> +                                         padapter->registrypriv.power_mgnt,
> +                                         padapter->registrypriv.smart_ps);
>                 }
>         }
>  }
> @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
>                                                            &pframe[10], 6);
>                         }
>                         if (pqospriv->qos_option == 1)
> -                                       priority[0] = (u8)pxmitframe->
> -                                                     attrib.priority;
> +                               priority[0] = (u8)pxmitframe->attrib.priority;
>                         r8712_secmicappend(&micdata, &priority[0], 4);
>                         payload = pframe;
>                         for (curfragnum = 0; curfragnum < pattrib->nr_frags;
>                              curfragnum++) {
>                                 payload = (u8 *)RND4((addr_t)(payload));
> -                               payload = payload + pattrib->
> -                                         hdrlen + pattrib->iv_len;
> +                               payload = payload + pattrib->hdrlen +
> +                                         pattrib->iv_len;
>                                 if ((curfragnum + 1) == pattrib->nr_frags) {
>                                         length = pattrib->last_txcmdsz -
>                                                   pattrib->hdrlen -
> --
> 2.7.4
>


Hi all,


A gentle reminder for my small patch. Some comments will be most helpful.


Regards, Prasant Jalan