linux-kernel - Re: [PATCH 2/2] staging: sm750fb: removed line continuations in quoted strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2017 22:03:34 +0530
From:   Prasant Jalan <prasant.jalan@...il.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     sudip.mukherjee@...ethink.co.uk, teddy.wang@...iconmotion.com,
        Greg KH <gregkh@...uxfoundation.org>,
        linux-fbdev@...r.kernel.org,
        driverdevel <devel@...verdev.osuosl.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Prasant Jalan <prasant.jalan@...il.com>
Subject: Re: [PATCH 2/2] staging: sm750fb: removed line continuations in
 quoted strings

On Sat, Apr 1, 2017 at 12:40 AM, Prasant Jalan <prasant.jalan@...il.com> wrote:
> checkpatch gives WARNING: Avoid line continuations in quoted strings.
>
> Trivial fix by removing line continuations and adding another quote at
> the start of next line.
>
> Signed-off-by: Prasant Jalan <prasant.jalan@...il.com>
> ---
>  drivers/staging/sm750fb/sm750.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 445c68d..386d4ad 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -837,15 +837,15 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
>
>         /* some member of info->var had been set by fb_find_mode */
>
> -       pr_info("Member of info->var is :\n\
> -               xres=%d\n\
> -               yres=%d\n\
> -               xres_virtual=%d\n\
> -               yres_virtual=%d\n\
> -               xoffset=%d\n\
> -               yoffset=%d\n\
> -               bits_per_pixel=%d\n \
> -               ...\n",
> +       pr_info("Member of info->var is :\n"
> +               "xres=%d\n"
> +               "yres=%d\n"
> +               "xres_virtual=%d\n"
> +               "yres_virtual=%d\n"
> +               "xoffset=%d\n"
> +               "yoffset=%d\n"
> +               "bits_per_pixel=%d\n"
> +               " ...\n",
>                 var->xres,
>                 var->yres,
>                 var->xres_virtual,
> --
> 2.7.4
>

Hi All,


A gentle reminder for my patches.
Any comments or updates will be helpful!


Regards, Prasant